This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Fix for…in loop handling #36
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regexp engine and the shell grammar don't agree on what comprises
a “word boundary”. This leads to problems where a command or path
ending in a shell keyword would be interpreted as that keyword.
This change replaces `\b` word boundary matchers with lookahead/-behind
matchers on whitespace, line breaks, and command separators (";" and "&").
It also eliminates ad-hoc custom word boundaries, where subsets of [-=/]
were pre- or appended to some word boundaries,
which fixed some similar problems.
The `in` keyword of the “for…in” loop is optional. In contrast, the variable name preceding it is required and must be a valid variable name, not an arbitrary string.
The for…in loop is much more common than the C-style for loop. The snippets package doesn’t seem to support transformations in snippet output yet, so this change adds a bare bones version that always inserts the (optional) in keyword.
|
@mkhl please keep the PRs separate in order to make reviewing easier. Thanks! |
|
@50Wliu I’m not quite sure how to keep them separate, since they are not independent. Would it be OK if I closed this one and reopened it once we’re done with #35? |
|
@50Wliu My intention was to go the other way because I believe #35 to be the more obvious (if larger) change. Your comments indicate that I haven’t done a good job though. :-) I think holding off on this until after #35 is done would cause the least effort. Whether you’d prefer I close this for that period is your call. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes for…in loop handling by
This pull request includes #35, which it would otherwise conflict with.