This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Add Greek characters to list of acceptable prompt-symbols #85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR enables Greek characters to be tokenised as prompt-string symbols in
shell-session
snippets:As the above snippet illustrates, the lines beginning with
λ
aren't being scoped as command lines.Compare with
$
:Note:
My shell's
PS1
isn't an isolated case. Lambda calculus, functional programming, and probably Half-life have helped propagate spiffy-looking Greek things in any notation intended to look mathematical or programming-related.Mocha's homepage features screenshots which also show
λ
in use.Alternate Designs
I thought to include
\p{S}
in the pattern-block, which matches anything with a UnicodeSymbol
property.The scope was too broad, and compatibility issues between Oniguruma and PCRE reared its ugly head.
Thankfully, both engines agree on the syntax for matching Unicode script-properties.
Benefits
Improved highlighting on GitHub. Specifically in README files, where example usage often takes the form of a terminal session's output.
Possible Drawbacks / Applicable Issues
None I can think of.