New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added snippets and tsx setting #3

Merged
merged 4 commits into from Sep 26, 2017

Conversation

Projects
None yet
2 participants
@torn4dom4n
Contributor

torn4dom4n commented Sep 16, 2017

Fixes broken snippets from #2 and add tsx settings
/cc @damieng

@torn4dom4n torn4dom4n changed the title from Added TypeScript and TypeScriptReact snippets to Added snippets and tsx setting Sep 16, 2017

@damieng

This comment has been minimized.

Show comment
Hide comment
@damieng

damieng Sep 17, 2017

Contributor

Are these from the upstream Microsoft package or from elsewhere? I ask because they are tending to use JSON everywhere but these are in CSON format.

Contributor

damieng commented Sep 17, 2017

Are these from the upstream Microsoft package or from elsewhere? I ask because they are tending to use JSON everywhere but these are in CSON format.

@torn4dom4n

This comment has been minimized.

Show comment
Hide comment
@torn4dom4n
Contributor

torn4dom4n commented Sep 17, 2017

@damieng

This comment has been minimized.

Show comment
Hide comment
@damieng

damieng Sep 17, 2017

Contributor
Contributor

damieng commented Sep 17, 2017

@@ -0,0 +1,257 @@
{
".source.ts": {

This comment has been minimized.

@torn4dom4n

torn4dom4n Sep 17, 2017

Contributor

Add .source.ts

@torn4dom4n

torn4dom4n Sep 17, 2017

Contributor

Add .source.ts

"body": [
"",
"public get ${1:value}() : ${2:string} {",
"\t${3:return $0}",

This comment has been minimized.

@torn4dom4n

torn4dom4n Sep 17, 2017

Contributor

Add \t

@torn4dom4n

torn4dom4n Sep 17, 2017

Contributor

Add \t

"",
"private _${1:value} : ${2:string};",
"public get ${1:value}() : ${2:string} {",
"\treturn this._${1:value};",

This comment has been minimized.

@torn4dom4n

torn4dom4n Sep 17, 2017

Contributor

Add \t

@torn4dom4n

torn4dom4n Sep 17, 2017

Contributor

Add \t

"\treturn this._${1:value};",
"}",
"public set ${1:value}(v : ${2:string}) {",
"\tthis._${1:value} = v;",

This comment has been minimized.

@torn4dom4n

torn4dom4n Sep 17, 2017

Contributor

Add \t

@torn4dom4n

torn4dom4n Sep 17, 2017

Contributor

Add \t

"body": [
"",
"public set ${1:value}(v : ${2:string}) {",
"\tthis.$3 = v;",

This comment has been minimized.

@torn4dom4n

torn4dom4n Sep 17, 2017

Contributor

Add \t

@torn4dom4n

torn4dom4n Sep 17, 2017

Contributor

Add \t

@@ -0,0 +1,260 @@
{
".source.tsx": {

This comment has been minimized.

@torn4dom4n

torn4dom4n Sep 17, 2017

Contributor

Add .source.tsx

@torn4dom4n

torn4dom4n Sep 17, 2017

Contributor

Add .source.tsx

"body": [
"",
"public get ${1:value}() : ${2:string} {",
"\t${3:return $0}",

This comment has been minimized.

@torn4dom4n

torn4dom4n Sep 17, 2017

Contributor

Add \t

@torn4dom4n

torn4dom4n Sep 17, 2017

Contributor

Add \t

"",
"private _${1:value} : ${2:string};",
"public get ${1:value}() : ${2:string} {",
"\treturn this._${1:value};",

This comment has been minimized.

@torn4dom4n

torn4dom4n Sep 17, 2017

Contributor

Add \t

@torn4dom4n

torn4dom4n Sep 17, 2017

Contributor

Add \t

"\treturn this._${1:value};",
"}",
"public set ${1:value}(v : ${2:string}) {",
"\tthis._${1:value} = v;",

This comment has been minimized.

@torn4dom4n

torn4dom4n Sep 17, 2017

Contributor

Add \t

@torn4dom4n

torn4dom4n Sep 17, 2017

Contributor

Add \t

"body": [
"",
"public set ${1:value}(v : ${2:string}) {",
"\tthis.$3 = v;",

This comment has been minimized.

@torn4dom4n

torn4dom4n Sep 17, 2017

Contributor

Add \t

@torn4dom4n

torn4dom4n Sep 17, 2017

Contributor

Add \t

@torn4dom4n

This comment has been minimized.

Show comment
Hide comment
@torn4dom4n

torn4dom4n Sep 26, 2017

Contributor

Typescript extension edited snippets with Microsoft/vscode@f0281dd. It like what I did. I believe my snippets can work and keep up to date with change.
cc/ @damieng

Contributor

torn4dom4n commented Sep 26, 2017

Typescript extension edited snippets with Microsoft/vscode@f0281dd. It like what I did. I believe my snippets can work and keep up to date with change.
cc/ @damieng

@damieng

This comment has been minimized.

Show comment
Hide comment
@damieng

damieng Sep 26, 2017

Contributor

I'm just trying to make sure we can stay up to date with the original repo without some knowledge of what conversions are required being lost.

Contributor

damieng commented Sep 26, 2017

I'm just trying to make sure we can stay up to date with the original repo without some knowledge of what conversions are required being lost.

@damieng damieng merged commit b1777dd into atom:master Sep 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment