This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Added snippets and tsx setting #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torn4dom4n
changed the title
|
Are these from the upstream Microsoft package or from elsewhere? I ask because they are tending to use JSON everywhere but these are in CSON format. |
|
I used snippets from https://github.com/Microsoft/vscode/tree/master/extensions/typescript/snippets but I edited for Atom. |
|
What changed were made?
I'm trying to avoid a scenario where we can't keep up to date with their
repo and undocumented changes will cause that.
Were the other files unchanged?
…On Sun, Sep 17, 2017, 8:42 AM Nguyen Long Nhat ***@***.***> wrote:
I used snippets from
https://github.com/Microsoft/vscode/tree/master/extensions/typescript/snippets
but I edited for Atom.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAHQp5gI4t-wJbYthKGzDgzoA_kp3n7mks5sjT3tgaJpZM4PZ3WI>
.
|
torn4dom4n
commented
Sep 17, 2017
| @@ -0,0 +1,257 @@ | |||
| { | |||
| ".source.ts": { | |||
| "body": [ | ||
| "", | ||
| "public get ${1:value}() : ${2:string} {", | ||
| "\t${3:return $0}", |
| "", | ||
| "private _${1:value} : ${2:string};", | ||
| "public get ${1:value}() : ${2:string} {", | ||
| "\treturn this._${1:value};", |
| "\treturn this._${1:value};", | ||
| "}", | ||
| "public set ${1:value}(v : ${2:string}) {", | ||
| "\tthis._${1:value} = v;", |
| "body": [ | ||
| "", | ||
| "public set ${1:value}(v : ${2:string}) {", | ||
| "\tthis.$3 = v;", |
torn4dom4n
commented
Sep 17, 2017
| @@ -0,0 +1,260 @@ | |||
| { | |||
| ".source.tsx": { | |||
| "body": [ | ||
| "", | ||
| "public get ${1:value}() : ${2:string} {", | ||
| "\t${3:return $0}", |
| "", | ||
| "private _${1:value} : ${2:string};", | ||
| "public get ${1:value}() : ${2:string} {", | ||
| "\treturn this._${1:value};", |
| "\treturn this._${1:value};", | ||
| "}", | ||
| "public set ${1:value}(v : ${2:string}) {", | ||
| "\tthis._${1:value} = v;", |
| "body": [ | ||
| "", | ||
| "public set ${1:value}(v : ${2:string}) {", | ||
| "\tthis.$3 = v;", |
|
Typescript extension edited snippets with microsoft/vscode@f0281dd. It like what I did. I believe my snippets can work and keep up to date with change. |
|
I'm just trying to make sure we can stay up to date with the original repo without some knowledge of what conversions are required being lost. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes broken snippets from #2 and add tsx settings
/cc @damieng