Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snippets to cson format #41

Merged
merged 1 commit into from Sep 24, 2019
Merged

Update snippets to cson format #41

merged 1 commit into from Sep 24, 2019

Conversation

@Jorys-Paulin
Copy link
Contributor

Jorys-Paulin commented Sep 20, 2019

Description of the Change

This pull request updates the TypeScript snippets from JSON definition files to one CSON definition file. The move to CSON fixes a bug where the snippets don't work because the body attribute of each snippet was an array and not a string, which wasn't supported by Atom, making the snippets not work at all.

Alternate Designs

I modified the JSON files to transform the arrays into strings, using \n characters for new lines.
In the end, I chose to move to CSON, so to be more in-line with other packages, like language-javascript

Benefits

The snippets will work again, fixing the bug. The snippets will also be in CSON, so more consistant with other packages.

Possible Drawbacks

The new snippets are the same as the originals. They haven't been updated to reflect new ones added to the javascript package, for example.

Applicable Issues

Fixes #40

@rsese rsese added the triaged label Sep 20, 2019
@lee-dohm

This comment has been minimized.

Copy link
Member

lee-dohm commented Sep 24, 2019

Thanks very much for the contribution!

@lee-dohm lee-dohm merged commit 41a33d4 into atom:master Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.