Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesUpdate snippets to cson format #41
Merged
+222
−532
Conversation
This comment has been minimized.
This comment has been minimized.
|
Thanks very much for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Jorys-Paulin commentedSep 20, 2019
•
edited by lee-dohm
Description of the Change
This pull request updates the TypeScript snippets from JSON definition files to one CSON definition file. The move to CSON fixes a bug where the snippets don't work because the
bodyattribute of each snippet was an array and not a string, which wasn't supported by Atom, making the snippets not work at all.Alternate Designs
I modified the JSON files to transform the arrays into strings, using
\ncharacters for new lines.In the end, I chose to move to CSON, so to be more in-line with other packages, like
language-javascriptBenefits
The snippets will work again, fixing the bug. The snippets will also be in CSON, so more consistant with other packages.
Possible Drawbacks
The new snippets are the same as the originals. They haven't been updated to reflect new ones added to the javascript package, for example.
Applicable Issues
Fixes #40