fileTypes

[sharedprophet]

Description of the Change

Looking at the grammar registry code, having the file types in here seems important.

Alternate Designs

I think without this the user has to set up custom overrides in their config, but that can't be done in the settings UI.

Benefits

Restore functionality that was lost from pulling in VS Code grammars directly.

Possible Drawbacks

None.

Applicable Issues

None yet.

[micaelmbagira]

@lkashef @darangi can we merge that and release? 1.43.0 is broken.

[Arcanemagus]

Please enable Tree-sitter parsers if you are experiencing issues with Atom v1.43.0, this only affects the TextMate grammar which is no longer actively maintained by the Atom team.

[sharedprophet]

Can you not just merge this? For users using semanticolor, currently only TextMate grammars can be supported.

[HugoMcPhee]

would also appreciate this as a solution to support semanticolor. on atom 1.42 as workaround but would be great to update, thanks

Edit: in the meantime here's what I did to get it working in the latest atom,

• Fork/download zip of atom/language-typescript
• Replace these files ( grammars/ TypeScript.json and TypeScriptReact.json ) with the same files from this pull request
• In the new language-typescript folder, run apm install (I had to use nodejs 10 or 11 and windows-build-tools for node-gyp to work) , then run apm link
  after that typescript with textmate should work again in atom

If there's a package build error in atom, it can be fixed by removing the tree-sitter grammars from the fork's grammars folder, and removing the tree-sitter dependency from package.json

[lkashef]

Hey @sharedprophet, thanks for the contribution 🙇‍♂️

We decided to accept this PR since it's trivial, however as a gentle reminder, Atom has moved away from using TextMate.

Looking forward to collaborate on your suggestions to add support for Semantic Syntax Highlighting to Tree-Sitter.

---

A quick reminder for the folks reporting the same issue on an outdated atom versions, please consider updating to the latest version of atom to receive the updates (or try out atom.io/nightly to get the updates faster)