Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fileTypes #44

Merged
merged 2 commits into from Jun 12, 2020
Merged

fileTypes #44

merged 2 commits into from Jun 12, 2020

Conversation

sharedprophet
Copy link
Contributor

@sharedprophet sharedprophet commented Dec 3, 2019

Description of the Change

Looking at the grammar registry code, having the file types in here seems important.

Alternate Designs

I think without this the user has to set up custom overrides in their config, but that can't be done in the settings UI.

Benefits

Restore functionality that was lost from pulling in VS Code grammars directly.

Possible Drawbacks

None.

Applicable Issues

None yet.

sharedprophet added 2 commits Dec 3, 2019
Looking at the grammar registry code, this seems important.
@jonboiser

This comment has been minimized.

@Arcanemagus

This comment has been minimized.

@micaelmbagira
Copy link

micaelmbagira commented Jan 16, 2020

@lkashef @darangi can we merge that and release? 1.43.0 is broken.

@Arcanemagus
Copy link
Member

Arcanemagus commented Jan 16, 2020

Please enable Tree-sitter parsers if you are experiencing issues with Atom v1.43.0, this only affects the TextMate grammar which is no longer actively maintained by the Atom team.

@sharedprophet
Copy link
Contributor Author

sharedprophet commented Feb 20, 2020

Can you not just merge this? For users using semanticolor, currently only TextMate grammars can be supported.

@onebree

This comment has been minimized.

@HugoMcPhee
Copy link

HugoMcPhee commented Jun 7, 2020

would also appreciate this as a solution to support semanticolor. on atom 1.42 as workaround but would be great to update, thanks

Edit: in the meantime here's what I did to get it working in the latest atom,

  • Fork/download zip of atom/language-typescript
  • Replace these files ( grammars/ TypeScript.json and TypeScriptReact.json ) with the same files from this pull request
  • In the new language-typescript folder, run apm install (I had to use nodejs 10 or 11 and windows-build-tools for node-gyp to work) , then run apm link
    after that typescript with textmate should work again in atom

If there's a package build error in atom, it can be fixed by removing the tree-sitter grammars from the fork's grammars folder, and removing the tree-sitter dependency from package.json

@lkashef
Copy link
Contributor

lkashef commented Jun 12, 2020

Hey @sharedprophet, thanks for the contribution 🙇‍♂️

We decided to accept this PR since it's trivial, however as a gentle reminder, Atom has moved away from using TextMate.

Looking forward to collaborate on your suggestions to add support for Semantic Syntax Highlighting to Tree-Sitter.


A quick reminder for the folks reporting the same issue on an outdated atom versions, please consider updating to the latest version of atom to receive the updates (or try out atom.io/nightly to get the updates faster)

@lkashef lkashef merged commit 392397f into atom:master Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants