This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add support for JavaScript classes (ES6) #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nathansobo @darangi @lkashef Could you please merge this? 😃 |
aminya
force-pushed
the
ES6
branch
2 times, most recently
from
066f552
to
1e9e006
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This adds support for JavaScript classes (ES6). Now the classes that are defined in JavaScript can require the ES6 version of the code.
mixtois used in many packages as a dependency (e.g. minimap). This allows updating those packages to ES6 without the need to rewrite the code.This code pull-request does not touch the ES5 code, so it does not break anything.
Verification
Drawbacks
N/A
Release Notes