-
Notifications
You must be signed in to change notification settings - Fork 102
Add a settings view where one can disable snippets for certain packages #196
Conversation
Hey @dralletje I'm in the process of working in another PR for this repo and you will need to add tests (specs) to your fork.
I'm not part of the atom team btw... but I'm undergoing this process which is completely new to me. |
Is there anything preventing the merge? |
Yes, it needs specs. |
Hey @50Wliu (not sure if I need to ping you), but is this enough spec that I added? 😁 |
Eagerly awaiting this feature.. any updates? |
Just popping in to say that it's 2017 and this default snippet malarkey is still the thing which annoys me most frequently in life. Pretty please can this be reviewed (and merged). 😄 |
The concern I have about this is that you have to restart for things to take effect. As the PR currently stands, I am 👎 on merging because of this. The system that was used to disable keybindings doesn't have this problem. Perhaps you can model this ability on that PR? atom/atom#8130 |
Thanks for the feedback, @lee-dohm , I share the concern. |
Sounds good! Thanks very much for your patience and effort on this @dralletje 🙇 ✨ |
so long time... |
@NanerLee If you would like to see this happen, perhaps you could take a stab at improving the PR? |
Hi, I have added the ability to reload snippets without the need to restart on #242 |
@layonferreira Looks awesome! Thanks for picking up where I forgot hahaha 😁 First contribution including a test, good job :) |
Closing in favor of #242 |
I know it does look kind of hacky, but this is the way it should be done I think. I am yet to dive deeper so we can reload without restarting it, maybe be just fully reloading all snippets. Made this because of this issue #55