Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Add a settings view where one can disable snippets for certain packages #196

Closed
wants to merge 4 commits into from
Closed

Conversation

dralletje
Copy link

I know it does look kind of hacky, but this is the way it should be done I think. I am yet to dive deeper so we can reload without restarting it, maybe be just fully reloading all snippets. Made this because of this issue #55

@PierBover
Copy link
Contributor

Hey @dralletje

I'm in the process of working in another PR for this repo and you will need to add tests (specs) to your fork.

I'm not part of the atom team btw... but I'm undergoing this process which is completely new to me.

@aryzing
Copy link

aryzing commented Dec 10, 2016

Is there anything preventing the merge?

@winstliu
Copy link
Contributor

Yes, it needs specs.

@dralletje
Copy link
Author

Hey @50Wliu (not sure if I need to ping you), but is this enough spec that I added? 😁
I know it is only one test, I'm not very good with tests yet

@krabbypattified
Copy link

Eagerly awaiting this feature.. any updates?

@kvsm
Copy link

kvsm commented Jan 5, 2017

Just popping in to say that it's 2017 and this default snippet malarkey is still the thing which annoys me most frequently in life. Pretty please can this be reviewed (and merged). 😄

@lee-dohm
Copy link
Contributor

lee-dohm commented Feb 6, 2017

The concern I have about this is that you have to restart for things to take effect. As the PR currently stands, I am 👎 on merging because of this. The system that was used to disable keybindings doesn't have this problem. Perhaps you can model this ability on that PR? atom/atom#8130

@dralletje
Copy link
Author

Thanks for the feedback, @lee-dohm , I share the concern.
Let me come back to this later this week with a restart-less version :-)

@lee-dohm
Copy link
Contributor

lee-dohm commented Feb 6, 2017

Sounds good! Thanks very much for your patience and effort on this @dralletje 🙇 ✨

@NanerLee
Copy link

so long time...
Eagerly awaiting this feature

@lee-dohm
Copy link
Contributor

@NanerLee If you would like to see this happen, perhaps you could take a stab at improving the PR?

@layonferreira
Copy link

Hi, I have added the ability to reload snippets without the need to restart on #242

@dralletje
Copy link
Author

@layonferreira Looks awesome! Thanks for picking up where I forgot hahaha 😁 First contribution including a test, good job :)

@dralletje
Copy link
Author

Closing in favor of #242

@dralletje dralletje closed this Sep 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants