Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decaf the tests (2nd attempt) #299

Merged
merged 6 commits into from Jan 17, 2020
Merged

Decaf the tests (2nd attempt) #299

merged 6 commits into from Jan 17, 2020

Conversation

Aerijo
Copy link
Member

@Aerijo Aerijo commented Dec 29, 2019

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Decaffeinates the remaining CS files in this repo. The functionality of the tests should be unchanged (though some returns were removed, which caused an incorrectly failing test on my machine to pass).

Replaces #297, which ran the decaf before merging upstream changes, and so lost changes in the tests.

Alternate Designs

na

Benefits

Part of the process for introducing the features in #288

Possible Drawbacks

na

Applicable Issues

na

@Aerijo Aerijo mentioned this pull request Dec 29, 2019
spec/snippet-loading-spec.js Outdated Show resolved Hide resolved
@lkashef lkashef self-assigned this Dec 31, 2019
@lkashef lkashef added the triaged label Jan 1, 2020
@lkashef lkashef merged commit a595213 into atom:master Jan 17, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants