Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

MRU order gets randomly corrupted #314

Closed
gliviu opened this issue Apr 27, 2016 · 8 comments · Fixed by atom/atom-keymap#156
Closed

MRU order gets randomly corrupted #314

gliviu opened this issue Apr 27, 2016 · 8 comments · Fixed by atom/atom-keymap#156
Labels

Comments

@gliviu
Copy link

gliviu commented Apr 27, 2016

Atom 1.7.2 installed without any extension.
Pretty difficult to reproduce due to random nature. However here is what I've done:

  • open 3 tabs
  • switch tabs multiple times
  • after 20-30 switches the mru order should be broken
@amytruong
Copy link

I haven't been able to reproduce this but will keep an eye out since you did say it happens randomly. When you say the MRU order is broken, do you mean the tabs are out of the MRU order? Or does something else happen?

@gliviu
Copy link
Author

gliviu commented May 5, 2016

Tabs are out of mru order.

@gliviu
Copy link
Author

gliviu commented May 5, 2016

Here is a quick example.
1
Initially the order is 321. I ctrl+tab once and the order becomes 231. I ctrl+tab again and I expect to switch to tab 3. But it switches to 1.

@ngoue
Copy link

ngoue commented May 17, 2016

[Corrupted MRU Bug Report]

Repro Steps

  1. Open two new tabs
  2. Switch tabs using pane:show-item-1 or pane:switch-item-2 (this should work)
  3. Reorder tabs using pane:move-item-left or pane:move-item-right
  4. Try switching tabs again with pane:show-item-1 or pane:show-item-2
    NOTE Commands can be run either with keyboard shortcuts or from the command palette with the same result

Expected: Adjust order of tabs
Actual: MRU order gets corrupted

Command History

     -0:11.7 pane:show-item-1 (atom-text-editor.editor)
     -0:11.4 pane:show-item-2 (atom-text-editor.editor.is-focused)
     -0:10.3 pane:move-item-right (atom-text-editor.editor)
     -0:10.0 pane:move-item-left (atom-text-editor.editor)
     -0:09.1 pane:show-item-1 (atom-text-editor.editor)
     -0:08.7 pane:show-item-2 (atom-text-editor.editor)
     -0:08.4 pane:show-item-1 (atom-text-editor.editor.is-focused)
     -0:08.1 pane:show-item-2 (atom-text-editor.editor)

Versions

  • Atom: 1.7.3
  • Atom-Shell:
  • OS: Mac OS X 10.11.5
  • Misc
    • apm 1.9.2
    • npm 2.13.3
    • node 0.10.40
    • python 3.4.2
    • git 2.2.1

This report was created in and posted from the Atom editor using the package bug-report v0.7.1.

@ngoue
Copy link

ngoue commented May 17, 2016

It only takes me 1-2 moves left or right to reproduce.

@wprater
Copy link

wprater commented Aug 3, 2016

this happens quite often for myself as well.

@Ben3eeE
Copy link
Contributor

Ben3eeE commented Oct 10, 2016

This sounds like the issue that was fixed in #302. If you can reproduce this in Atom 1.11 or later please comment here and we will reopen.

@Ben3eeE Ben3eeE closed this as completed Oct 10, 2016
@iolsen iolsen reopened this Oct 11, 2016
@iolsen
Copy link
Contributor

iolsen commented Oct 11, 2016

I've discovered that the key-up key binding responsible for resetting the MRU stack isn't reliably being caught. I expect that's the primary cause of this issue. There will be a fix soon, likely this week, and I'll reference this issue and reclose at that time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants