Incorrect deprecate warning when MarkerLayer::markRange passed persistent options

[t9md]

I'm working on Atom master branch to catch-up display-layer.
cc @as-cii

Then I noticed this warning.

  Assigning custom properties to a marker when creating/copying it is
  deprecated. Please, consider storing the custom properties you need in
  some other object in your package, keyed by the marker's id property.

Only following code shows warning.

  editor.markBufferRange editor.getSelectedBufferRange(),
    invalidate: 'never'
    persistent: false

As far as I check, persistent option is for MarkerLayer but this options is validated by Marker's Marker.extractParams(options).
Should delete options.persitent before passing Marker.extractParams()?

[as-cii]

With #149 we have basically moved all the concerns about markers' lifetime and persistence to marker layers and, as a result, passing that option won't actually persist the marker across reloads. This is how the new API looks like (you can also take a look at some of the core packages, like bookmarks, to see how we've switched to marker layers):

let markerLayer = editor.addMarkerLayer({persistent: true})
markerLayer.markRange(position)

You can also optionally pass a maintainHistory parameter to addMarkerLayer which, when true, makes sure to restore your markers when undo or redos are performed.

[t9md]

Thanks, understood.
So this api doc has to be updated, it says accept persistent options, but @defaultMarkerLayer is created without any options(@defaultMarkerLayer = @displayLayer.addMarkerLayer())
https://github.com/atom/atom/blob/master/src/text-editor.coffee#L1691-L1724

Also TextEditor::markScreenRange has to be updated.

[as-cii]

Thanks for the heads-up, @t9md! 🙇 I'll make sure to update those docs as soon as possible. 📜

[as-cii]

Updated in atom/atom@e3790b8.

[t9md]

Thanks! Not only for this, all your heavy effort to improve Atom at very fundamental layer!!