This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Convert TextBuffer to JavaScript #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbrunsfeld
force-pushed
the
mb-decaf-text-buffer
branch
4 times, most recently
from
4318122 to
4130376
Compare
maxbrunsfeld
force-pushed
the
mb-decaf-text-buffer
branch
from
4130376 to
8168c4e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs atom/atom#17938
I used
async/awaitsyntax for a couple of methods, which has a slight behavior change in that errors are returned via promise rejections instead of being synchronously thrown. I think that'll be fine for Atom, but I'll be keeping an eye out.