This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Always use serialized text when deserializing #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevinsawicki Could you take a look at this one, since you worked on the file loading/watching logic? It's seeming like it's ok to just always use the serialized text when deserializing the buffer, but I might be missing something. |
| @@ -107,7 +107,6 @@ class TextBuffer | |||
| @transactCallDepth = 0 | |||
| @digestWhenLastPersisted = params?.digestWhenLastPersisted ? false | |||
| @modifiedWhenLastPersisted = params?.modifiedWhenLastPersisted ? false | |||
There was a problem hiding this comment.
I think @modifiedWhenLastPersisted can be removed now too, it appears unused
This looks okay to me, I'm not 100% sure why these nuances were there previously but if the specs are green then I'm good with this. I did leave one minor comment about another piece of serialized state that could possibly be removed now as well since it is unused. |
Conflicts: package.json
maxbrunsfeld
force-pushed
the
mb-fix-undo-history-after-deserialization
branch
from
9501792 to
f3fa3d0
Compare
maxbrunsfeld
pushed a commit
that referenced
this pull request
Sep 15, 2015
…ation Always use serialized text when deserializing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that the fix added in #95 doesn't always work. When the file was saved, the undo history was still lost on reload. This fixes that.
Depends on atom/node-pathwatcher#85