Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Tree view focuses on reveal regardless of setting. #1070

@phyllisstein

Description

@phyllisstein

Prerequisites

Description

Hey Atomizers! I hope this isn't a dupe of the infamous #858, but I'm having some trouble with tree-view@0.217.0-3. I installed the new beta with Tree View's "Auto Reveal" setting enabled and "Focus on Reveal" disabled. Heretofore, that's always meant that switching from one file to another would show its location in the tree without pulling focus from my editor, which I understand to be the expected behavior. But as of this version, the editor consistently loses focus when I open or change files, and I wind up focused on the tree.

Here's a quick safe-mode screencast illustrating the issue:

2017-04-17 16_23_15

As you can see, it doesn't seem to affect tab clicks, but it does affect opening files and navigating with ++[/].

I'd be grateful for any guidance you can provide! Please let me know if I can furnish any more troubleshooting data.

Steps to Reproduce

  1. Enable "Auto Reveal" in Tree View and disable "Focus on Reveal."
  2. Double-click a file in Tree View to open it. Observe that the editor loses focus.
  3. Open another file, and refocus the editor.
  4. Click the first file's tab. Observe that the editor does not lose focus.
  5. Use the "Previous/Next Tab" keyboard shortcuts to navigate to the second file's tab. Observe that the editor loses focus.

Expected behavior: The editor should stay focused throughout.

Actual behavior: tree-view steals focus when navigating with the keyboard or opening new files.

Reproduces how often: 100%

Versions

❯ atom --version
Atom    : 1.17.0-beta2
Electron: 1.3.14
Chrome  : 52.0.2743.82
Node    : 6.5.0

❯ apm --version
apm  1.17.0
npm  3.10.5
node 6.9.5 x64
python 2.7.13
git 2.12.2

❯ system_profiler SPSoftwareDataType
Software:

    System Software Overview:

      System Version: macOS 10.12.4 (16E195)
      Kernel Version: Darwin 16.5.0
      Boot Volume: Macintosh HD
      Boot Mode: Normal
      Computer Name: Zbornak
      User Name: Daniel P. Shannon (daniel)
      Secure Virtual Memory: Enabled
      System Integrity Protection: Disabled
      Time since boot: 3:57

Additional Information

💖

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions