Background is not completely filled

[susisu]

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
  • Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
  • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
  • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

When tree view's width is smaller than its content width, the background (including selected item highlight) is not completely filled.

Steps to Reproduce

1. Show the tree view (by opening some project)
2. Make tree view's width smaller than its content width
3. Scroll horizontally

Expected behavior:
Background should be completely filled.

Actual behavior:
Background is not completely filled, like this:

Reproduces how often:
100%.
This happens for any themes.

Versions

Atom    : 1.17.0
Electron: 1.3.15
Chrome  : 52.0.2743.82
Node    : 6.5.0

tree-view version: 0.217.0-7

[rsese]

Thanks for the report!

100%.
This happens for any themes.

Hmm, I do see that gap with Atom Light and Dark but not with the One themes e.g.:

Do you see differently with the One themes?

[Cthulahoop]

I'm seeing the same issue, and it's true for all themes including the One themes. In your image, you need to scroll the list horizontally to see that the highlight element is rendered only as wide as the dock element. I think the ol.full-menu element is where the truncation happens, but not positive on a fix.

[susisu]

@rsese As said above, if you scroll horizontally, you can see this also happens for the One themes.
(Maybe my screenshot was not good, sorry.)

There was .tree-view-scroller element in the old versions, from which the background width is inherited.
In the latest version, there is no such wrapper element.
This is why I said the problem can happen for any themes.

[simurai]

@susisu There was .tree-view-scroller element in the old versions

Right. Probably happened during the "move into docks": #1056

To make the selection expand, we might can add another wrapper that acts the same as .tree-view-scroller. I'll take a look.

[rsese]

Weird, though my screenshot wasn't scrolled I'm almost positive I didn't see that gap but I do now - thanks for the clarification @Cthulahoop @susisu 🙇 and thanks for the 👓 @simurai 🙌

[hayzey]

+1