This repository was archived by the owner on Dec 15, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 361
Update editors when containing directory is renamed or removed (redux) #1049
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
5981f47
Fire events when creating, moving or deleting items
Alhadis c088550
Add TreeView methods to attach file-event handlers
Alhadis 1488a66
Add specs for 5981f47 and c088550
Alhadis 74b1b7e
Fix typos and polish punctuation of spec titles
Alhadis 34a5e1d
Merge branch 'master' into file-events
Alhadis 75bb6b6
Merge branch 'master' into file-events
Alhadis b5c2755
Merge branch 'master' into file-events
Alhadis fab5074
Resolve conflicts with v0.213.1
Alhadis 2ffc575
Resolve conflicts with v0.214.0
Alhadis 271949c
Resolve conflicts with v0.215.1
Alhadis 6d07f77
Update editor paths when containing directory is renamed via move dialog
kuychaco 081ead9
Update editor paths when containing directory is renamed via drag'n'drop
kuychaco 49c6893
Extract helper method updateEditorsForPath
kuychaco 06d227f
Close editors when containing directory is removed
kuychaco 95fb486
Merge branch 'file-events' of https://github.com/Cutlery-Drawer/tree-…
15f87c7
Update Move and CopyDialog to take callbacks
2642b82
Standardize event params
b86a328
Update tests
425f396
:fire: console.log
9a5e04b
Betterer names
b17769f
Merge ku-mkt-udpate-editors-after-folder-operations, using new strategy
b5d228d
Use new hooks for updating editors
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe not destroy them if they have unsaved changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, this code path didn't change (it was only moved). I'll double check again but I was pretty sure that it left the editor open with unsaved changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, you're right - it definitely does get destroyed. Sounds like a bug to me! I'll check for another issue and if one doesn't exist, create one. Thanks.