This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Add backward-compatible support for new pending item API #752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 28, 2016 08:21
This adds backward-compatible checks for the new pending item APIs, and falls back to using `Item::terminatePendingState` if they're not supported in the current Atom environment.
BinaryMuse
pushed a commit
that referenced
this pull request
Feb 29, 2016
…files Add backward-compatible support for new pending item API
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds backward-compatible checks for the new pending item APIs, and falls back to using
Item::terminatePendingStateif they're not supported in the current Atom environment.Fixes atom/atom#10995 until #741 can be merged.
/cc @kuychaco