Skip to content
This repository was archived by the owner on Apr 6, 2018. It is now read-only.

Conversation

dsandstrom
Copy link

Fixes #550.

  • I had to add a different word regex to add $. I'd rather have an option built into the Cursor class instead of adding it to this package. I can submit that PR if that is a better approach.
  • I wanted to set the allowEOL option from vim-state.coffee, but couldn't figure out how to do that. Right now, the custom word regex is set for all delete operators.
  • In vim, I noticed that dw also deletes the preceeding space, which this PR doesn't fix.

@jacekkopecky
Copy link
Contributor

@dsandstrom can you please clarify what you mean by dw deleting the preceding space in VIM? I can't seem to see such behaviour. I'm asking because this is related to #555 and related stuff I've had my eye on. 8-)

@dsandstrom
Copy link
Author

I guess I was mistaken. I was thinking that if you entered dw when your cursor was before the second word (first |second), that vim was also deleting the space after the first word. But it is not the case.

@chrisvdb
Copy link

chrisvdb commented May 7, 2015

hi guys, is this fix production ready? If so, can this fix be included in the next release? Issue #550 hits me 10+ times per day.

@dsandstrom
Copy link
Author

@chrisvdb No, it's more of a proof of concept. I'm waiting to hear from @maxbrunsfeld or @kevinsawicki for some feedback.

@Zaba999
Copy link

Zaba999 commented Jul 7, 2015

👍

@@ -201,7 +201,18 @@ class MoveToNextWord extends Motion
wordRegex: null
operatesInclusively: false

wordRegExp: (cursor, {includeNonWordCharacters}={}) ->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this method ever called with a second argument? I only see the one call on line 215.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I just copied cursor's regex function: https://github.com/atom/atom/blob/37cb6b6d9e2be35af51b4e7e812b833efc24ce11/src/cursor.coffee#L642. My original intent was to merge the changes back to Atom.

@lee-dohm
Copy link
Contributor

lee-dohm commented Apr 5, 2018

As stated in the README, this package is no longer maintained and is deprecated. We recommend that people use the vim-mode-plus package instead. Because of this, we are archiving this repository and closing all issues and pull requests. Thanks very much for your support and contributions!

@lee-dohm lee-dohm closed this Apr 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete word (dw) should not delete line break
6 participants