[Fix] Skip navigation for modified keys events and some "target" values #21
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
risen228
changed the title
sergeysova
approved these changes
Jul 14, 2023
Kelin2025
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when using
Linkcomponent, if you try to open a link in a new tab, the behavior will be unexpected and default navigation will occur in the current tab. The same applies to links withtarget="_blank"attribute.This PR adds a new logical steps, checking for
targetattribute and the mod keys (cmd, ctrl, alt, shift). When the key is pressed - the defaultabehavior will be used (if not default prevented by used).