Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using os.hostname() not working for users #160

Closed
ddgenome opened this issue Aug 28, 2018 · 6 comments · Fixed by #161
Closed

Using os.hostname() not working for users #160

ddgenome opened this issue Aug 28, 2018 · 6 comments · Fixed by #161
Assignees
Labels
bug Something isn't working changelog:fixed Add this issue or pull request to fixed changelog section

Comments

@ddgenome
Copy link
Contributor

os.hostname() is not working reliably for users. We should use localhost or, if you want to avoid problems with people who do not have localhost configured properly, 127.0.0.1.

@ddgenome ddgenome added bug Something isn't working changelog:fixed Add this issue or pull request to fixed changelog section labels Aug 28, 2018
@cdupuis
Copy link
Member

cdupuis commented Aug 28, 2018

So, you’re saying os.hostname() doesn’t return the correct host name?

@ddgenome
Copy link
Contributor Author

It returns a host name that is not resolvable to an IP address.

@cdupuis
Copy link
Member

cdupuis commented Aug 28, 2018

So, do we want localhost or 127.0.0.1? I probably also want to make that configurable in the client.config.json approach.

@ddgenome
Copy link
Contributor Author

Using the IP address should be safer, if less intuitive.

@johnsonr
Copy link
Contributor

This is in local? There's a strategy interface for this: LocalHostUrlAliaser. The default strategy should pick up some configuration or it should be added on config somewhere

@cdupuis cdupuis self-assigned this Aug 28, 2018
@cdupuis
Copy link
Member

cdupuis commented Aug 28, 2018

Yeah, I'm on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working changelog:fixed Add this issue or pull request to fixed changelog section
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants