Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently use local configuration; read hostname from configuration #161

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

cdupuis
Copy link
Member

@cdupuis cdupuis commented Aug 29, 2018

This changes the code throughout to use the local configuration object. Read the hostname from the configuration if possible and fall back to user config and finally to "127.0.0.1" if no configuration is provided.

  • A couple of renames to make it more in-line with sdm-core.
  • Change the logger to log into .atomist/log and expose the url so that we can show the log url on failed goals
  • Delint

fixes #160

@cdupuis cdupuis added changelog:changed Add this issue or pull request to changed changelog section auto-merge:on-approve Auto-merge on review approvals labels Aug 29, 2018
@atomist-bot
Copy link
Contributor

Pull request auto merged by Atomist.

  • 1 approved review by @johnsonr
  • 2 successful checks

[atomist:generated] [auto-merge:on-approve]

@atomist-bot atomist-bot merged commit 343dcd7 into master Aug 29, 2018
@atomist-bot atomist-bot deleted the local-configuration branch August 29, 2018 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge:on-approve Auto-merge on review approvals changelog:changed Add this issue or pull request to changed changelog section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using os.hostname() not working for users
3 participants