chore: remove x/params module #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x/params was there in gaia v15 for retro-compatibility and maybe because of the x/globalfee modules that didn't have its own `MsgUpdateParams`. For a new chain there's no need for it, as all modules have migrated to the new params paradigm, where their params are now stored in their own store rather than in the x/params module store (see [1]) [1]: https://github.com/cosmos/cosmos-sdk/blob/main/docs/architecture/adr-046-module-params.md
giunatale
approved these changes
Sep 23, 2024
tbruyelle
added a commit
that referenced
this pull request
Sep 27, 2024
This reverts commit 0ec77cc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x/params was there in gaia v15 for retro-compatibility and maybe because of the x/globalfee module that didn't have its own
MsgUpdateParams. For a new chain there's no need for it, as all modules have migrated to the new params paradigm, where their params are now stored in their own store rather than in the x/params module store (see 1)