Skip to content

feat(gov): disable validator vote inheritance #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2024
Merged

feat(gov): disable validator vote inheritance #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
973dd92
feat(gov): disable validator vote inheritance
tbruyelle Aug 30, 2024
c35523a
Update x/gov/keeper/tally_test.go
tbruyelle Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions x/gov/keeper/tally.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ func (keeper Keeper) Tally(ctx sdk.Context, proposal v1.Proposal) (passes bool,
return false
})

/* DISABLED on AtomOne - Voting can only be done with your own stake
// iterate over the validators again to tally their voting power
for _, val := range currValidators {
if len(val.Vote) == 0 {
Expand All @@ -89,6 +90,7 @@ func (keeper Keeper) Tally(ctx sdk.Context, proposal v1.Proposal) (passes bool,
}
totalVotingPower = totalVotingPower.Add(votingPower)
}
*/

params := keeper.GetParams(ctx)
tallyResults = v1.NewTallyResultFromMap(results)
Expand Down
6 changes: 3 additions & 3 deletions x/gov/keeper/tally_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,18 +213,18 @@ func TestTally(t *testing.T) {
},
},
{
name: "validator votes yes, inherit delegations",
name: "validator votes yes, doesn't inherit delegations",
setup: func(s *tallyFixture) {
s.delegate(s.delAddrs[0], s.valAddrs[0], 2)
s.delegate(s.delAddrs[1], s.valAddrs[0], 2)
s.validatorVote(s.valAddrs[0], v1.VoteOption_VOTE_OPTION_NO)
},
expectedPass: false,
expectedBurn: false,
expectedBurn: true, // burn because quorum not reached
expectedTally: v1.TallyResult{
YesCount: "0",
AbstainCount: "0",
NoCount: "5",
NoCount: "1",
NoWithVetoCount: "0",
},
},
Expand Down
Loading