Replace ellipsis unpacking with list to rlang::list2()
#148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstackhouse
changed the title
rlang::list2()
mstackhouse
requested review from
asbates
and removed request for
elimillera
asbates
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Looks good!
I've tried to run all the old code I had when I was deep into Tplyr and this issue came up. I also ran the M*V app with this branch installed and everything worked smoothly. I can't remember exactly what I was trying to do unfortunately, but given the reprex from the issue is resolved and all the tests pass, I think it's good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #111 we realized that ellipsis unpacking was broken in some contexts. This had to do with how ellipsis unpacking worked when passing in an object that was being injected.
rlang::list2(...)should be equivalent tolist(...)except in this type of circumstance.I took a broad approach of grep'ing the directory to find all these lines - so it could use a cross check to see if I got the right cases. I also put a test in here to make sure the capability worked. I didn't test every single circumstance where this might occur. I think this is ok though because we know all prior functionality is passing, but in that test I verified that injecting a value functions in the desired context.