Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export create_tbl() #6

Closed
thomas-neitmann opened this issue Jul 29, 2021 · 1 comment
Closed

Export create_tbl() #6

thomas-neitmann opened this issue Jul 29, 2021 · 1 comment
Assignees
@statasaurus

Comments

@thomas-neitmann
Copy link
Contributor

@statasaurus Thanks again for helping with building the Roche spec reader. After making some minor adjustments the reader now works properly and I incorporated it within an internal package. However, as the reader function makes use of the un-exported create_tbl() function I get a Note when running R CMD check which is not acceptable according to our package validation guidelines. Thus, please export this function. Thank you!
@mstackhouse
Copy link
Contributor

@statasaurus I don't have any issue with exporting this. Any concerns from your side?

@mstackhouse mstackhouse mentioned this issue Aug 6, 2021
Merged
statasaurus added a commit that referenced this issue Nov 19, 2021
@statasaurus
#15 create_tbl will return and exact match,
64b79e1 
#12 format not will be accepted lower and upper case like the rest of the inputs
#6 export create_tbl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@statasaurus statasaurus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thomas-neitmann @mstackhouse @statasaurus