Skip to content

add support for launching tests with php interpreters #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 1, 2016

Conversation

agallou
Copy link
Member

@agallou agallou commented May 14, 2016

fixes #36

agallou added 2 commits May 16, 2016 17:30
Conflicts:
	src/org/atoum/intellij/plugin/atoum/run/Runner.java
@jubianchi
Copy link
Member

My feedback on this feature: so far, I did not run any test with docker, but:

  • The configuration directive are not used:

capture d ecran 2016-05-18 a 10 59 05

But the plugin seems to only run /usr/bin/php ... when it should run /usr/bin/php -ddate.timzeon=UTC

  • The PHP interpreter should also be given to atoum via the -p argument, something like /usr/bin/php -ddate.timzeon=UTC vendor/bin/atoum -p '/usr/bin/php -ddate.timzeon=UTC' ... : if we don't do that, atoum will always use the default php binary which ha will find in the PATH so in the case of docker, it will probably not work.

@jubianchi
Copy link
Member

👍

@agallou agallou merged commit 1304db8 into atoum:master Oct 1, 2016
@agallou agallou deleted the docker branch October 1, 2016 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running tests with PHP in a docker container
2 participants