Add MSRV in cargo.toml #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this mean we could also jump to 2021 edition? Should we do that here or a follow up |
That would need |
|
I thought rust-version itself was tied to 1.56
…On Wed, Oct 27, 2021 at 1:53 PM Sympatron GmbH ***@***.***> wrote:
Does this mean we could also jump to 2021 edition? Should we do that here
or a follow up
That would need 1.56.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#535 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC5YNWWX2AQG4UFWW2R44OLUJBYGTANCNFSM5G2ZMCDQ>
.
|
|
I suppose you are technically correct. Previous Rust versions will just ignore it. But there is no way around it as far as I know. I think this info will still be interesting for users and could theoretically be used for CI. |
|
I’m just thinking, might as well go to 1.56 + 2021 edition if it’s the
first version to actually use it. One version doesn’t make much of a
difference, might as well get the benefit 🤷
…On Wed, Oct 27, 2021 at 3:49 PM Sympatron GmbH ***@***.***> wrote:
I suppose you are technically correct. Previous Rust versions will just
ignore it. But there is no way around it as far as I know. I think this
info will still be interesting for users and could theoretically be used
for CI.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#535 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC5YNWTBKQ7ZSR5V6E2YDGTUJCFZ7ANCNFSM5G2ZMCDQ>
.
|
|
Done. With 2021 edition cargo will complain about 2021 not being stable below |
|
@Sympatron Update the CHANGELOG and this should be good to go! |
kaizensparc
pushed a commit
to kaizensparc/atsamd
that referenced
this pull request
Dec 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just sets the
rust-versionincargo.tomlto1.55, because this will be our MSRV once #526 is merged.I don't know what our MSRV was before, but I don't think it matters much once #526 lands.The previous MSRV was1.46.