Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add 'status' command to the activate cli #582

Merged
merged 22 commits into from
May 23, 2024
Merged

feat: add 'status' command to the activate cli #582

merged 22 commits into from
May 23, 2024

Conversation

gkc
Copy link
Contributor

@gkc gkc commented May 20, 2024 •
edited
Loading

- What I did

  • feat: at_onboarding_cli: add 'status' command to the activate cli to check the status of an atSign
  • build: at_onboarding_cli: updated pubspec and changelog for version 1.6.0
  • test: fixed a bunch of test failures which were failing in such a way as to not cause the overall test job to fail

- How I did it
See commits / diffs

- How to verify it

  • Run the command e.g. dart bin/activate_cli.dart -a @no_such_atsign; echo $?

@gkc gkc changed the title Feat/add status command to auth cli feat: add 'status' command to the activate cli May 20, 2024
@gkc gkc requested a review from XavierChanth May 20, 2024 15:29
@gkc gkc requested a review from cpswan May 20, 2024 15:44
cpswan
cpswan requested changes May 20, 2024
View reviewed changes
packages/at_onboarding_cli/CHANGELOG.md Outdated
@@ -1,3 +1,6 @@
## 1.5.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 1.6.0 as this is definitely new functionality rather than a patch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpswan thank you yes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have made that change

@gkc
Copy link
Contributor Author

gkc commented May 20, 2024

Marking as draft until I understand why the at_onboarding_cli functional tests are failing

@gkc gkc marked this pull request as draft May 20, 2024 15:48
XavierChanth
XavierChanth previously approved these changes May 20, 2024
View reviewed changes
@gkc
Copy link
Contributor Author

gkc commented May 20, 2024 •
edited
Loading

Marking as draft until I understand why the at_onboarding_cli functional tests are failing

tests failing because of an atServer bug, will be resolved in v 3.0.46 see atsign-foundation/at_server#1958 ... until that has been merged to trunk and VE rebuilt, I will leave this PR as a draft

gkc added 10 commits May 22, 2024 12:39
@gkc
Merge remote-tracking branch 'origin/trunk' into feat/add-status-comm…
35a872a 
…and-to-auth-cli
@gkc
test: Fix functional test for appName & deviceName not supplied - the…
f4033cf 
…se are no longer mandatory for calls to .onboard

test: Fix functional test for enrollment denial
@gkc
test: fix functional test of enrollment denial
1d5ac59
@gkc
chore: removed some lint; ran dart format
59f497b
@gkc
chore: removed some lint; ran dart format
2c30f64
@gkc
test: Fixed test which was notionally verifying that the activate_cli…
204858b 
… was working but was using an atSign which had already been onboarded in another test
@gkc
test: changed fail-fast:false to fail-fast:true for the at_onboar…
ff116ce 
…ding_cli functional tests as previously the tests were failing but the check overall was not failing
@gkc
test: quick check to verify that the fail-fast strategy change has th…
0805d1c 
…e desired effect
@gkc
test: revert the fail-fast change, I was barking up the wrong tree
a5d319f
@gkc
test: revert the forced test failure
16eb1ae
@gkc gkc marked this pull request as ready for review May 22, 2024 12:42
@gkc gkc mentioned this pull request May 22, 2024
Closed
@gkc gkc requested a review from cpswan May 22, 2024 12:43
@gkc
Copy link
Contributor Author

gkc commented May 22, 2024

Marking as draft until I understand why the at_onboarding_cli functional tests are failing

tests failing because of an atServer bug, will be resolved in v 3.0.46 see atsign-foundation/at_server#1958 ... until that has been merged to trunk and VE rebuilt, I will leave this PR as a draft

ready for review

@gkc gkc requested a review from XavierChanth May 22, 2024 12:46
@gkc gkc merged commit e23e429 into trunk May 23, 2024
11 checks passed
@gkc gkc deleted the feat/add-status-command-to-auth-cli branch May 23, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierChanth XavierChanth XavierChanth approved these changes

@cpswan cpswan cpswan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gkc @cpswan @XavierChanth