Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add opcode to AAPXS SysEx8 packet format #175

Closed
4 tasks done
atsushieno opened this issue Sep 12, 2023 · 0 comments
Closed
4 tasks done

add opcode to AAPXS SysEx8 packet format #175

atsushieno opened this issue Sep 12, 2023 · 0 comments

Comments

@atsushieno
Copy link
Owner

atsushieno commented Sep 12, 2023 •
edited
Loading

Currently AAPXS "opcode" is not included in the packet format (it is assumed as head of the "data" section), but it should be an isolated field, just as Binder AIDL extension() function defines it so. If we do not do so, there will be incompatible interpretation on data field (and dataSize field).

TODOs:

  • add opcode field in the format description in midi.h
  • generator needs to take care of it
  • parser needs to take care of it
  • AudioPluginNode in PluginPlayer needs to take care of it
atsushieno added a commit that referenced this issue Sep 13, 2023
@atsushieno
bump cmidi2. Implement realtime-safe-ish set_preset operation in Plug…
c88c596 
…inPlayer.

Everything is still hacky; we should bring in another wrapping layer around
AAPXSClientInstance. context:

- #170 (comment)
- #171
- #175
- #169 (comment)

The code still does not bring in fairly good RT safety because it looks up
interned URI (because we cannot intern extension URIs that are sent by the
client). We will have to come up with something like LV2 URIDs and/or
reserved extension URI mappings (like well known TCP ports).

As for 0.7.8, this PoC would suffice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@atsushieno