-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: some MIDI synths do not generate valid audio output on hosts #14
Comments
Magical8bitPlug2 now generates sound on aaphostsample. |
SARAH: the plugin indeed processes note events, but for the final float outpu for each cycle, it is |
Magical8bitPlug2 generates sound on AudioPluginHost too. The differences between aaphostsample and AudioPluginHost are:
|
I figured out why OB-Xd does not generate output - it expects AudioPlayHead (via |
OB-Xd still fails to generate audible results even after I implemented AudioPlayback for JuceAAPWrapper. But I think I figured out why it happens.
Therefore, what would "fix" the problem is, that we implement aaphostsample MIDI messaging to not send note-offs in the same packet. It should be fairly doable. |
That was only part of the problem. Problem # 2 is that OBXdAudioProcessor (or any audio hprocessor?) expects output channels come first then input channels follow, whereas we handle the other way. Not sure if there is any indication on which pointer is which. |
context: #14 (comment) [This LV2Wrapper implementation](https://github.com/jpcima/JUCE/blob/develop%2Blv2/modules/juce_audio_plugin_client/LV2/juce_LV2_Wrapper.cpp) also implements AudioPlayhead, and IIRC JUCE VST3Wrapper also does.
context: #14 (comment) This fixes SARAH, Dexed, and OB-Xd i.e. everything started to generate sound. It is because all those synths use juce::Synthesizer which calls AudioBuffer.getWritePointer(0) (note this 0 part) i.e. it is order dependent.
With af6d79d all those sample synths are working with aaphostsample! |
juceaaphost is still weird. OB-Xd always crashes. Any other synths generate sound, but their key is weird. Also it frequently crashes. Needs further investigation. |
Since juceaaphost issue smells like another kind of bug, I would close this issue and file new one. |
While JUCE AudioPluginHost generates some audio outputs for Andes, it only generates noises on OBXd and Magical8bitPlug2. And no synth generates valid sound on aaphostsample.
Since MDA pianos generate valid outputs on both hosts it is specific to JUCE based instruments. Weird is that Andes still generates audible sound on aaphostsample...
It is confirmed on juce6 branch.
The text was updated successfully, but these errors were encountered: