Pnpm-accepted patches without EOF annotations fail under aube

[mwolson]

• Aube: 2.2.13, Linux x64
• Pnpm: 11.10.0 and 12.3.4
• Repro: https://github.com/mwolson/tmp-aube-issues/tree/main/pnpm-patch-missing-eof-marker

Aube fails with error applying hunk #1 when a patch retains an
unterminated final line as context but omits the canonical
\ No newline at end of file annotation.

Both pnpm versions apply the patch and preserve the absent trailing
newline. Adding the annotation makes aube succeed too.

The repro uses a two-line local package with no registry dependencies.
Each install gets fresh isolated storage. It tests both the missing
annotation and the correctly annotated patch.

I encountered this while patching react-native-keyboard-controller@1.21.13.
Adding four missing annotations made aube's frozen install succeed, with
all 616 package files matching pnpm's output byte-for-byte.

Could aube match pnpm's tolerance for the missing annotation?

[jdx]

Confirmed and opened a fix in #1515.

Aube was passing the patch directly to diffy, which compares newline bytes exactly: the final context line in the patch ends with a newline, while the source file's final line does not. The fix retries with an EOF annotation on matching final context, preserving the absent trailing newline. Explicit newline edits keep their existing behavior, and content mismatches still fail.

Your reproduction now passes both the canonical and missing-marker variants with the patched aube 2.2.13 build against pnpm 11.10.0 and 12.3.4 on macOS arm64, including its exact output-byte assertions. All 127 linker tests and workspace Clippy checks pass. Added regression coverage for CRLF, multiple hunks and shifted offsets, explicit newline changes, and content mismatches.

The fix is in the PR and has not been released yet; adding the missing annotations remains the workaround for the released version.

This comment was generated by Codex.

[mwolson]

Retested pnpm-patch-missing-eof-marker with aube 2.2.16 linux-x64 against pnpm 12.3.4. Both the canonical and missing-marker variants now pass, including the exact output-byte assertions.

Shipping fix: #1515 missing-eof-marker, included in 2.2.14.