Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGTK is underlinked #552

Closed
mikhailnov opened this issue May 30, 2020 · 7 comments
Closed

wxGTK is underlinked #552

mikhailnov opened this issue May 30, 2020 · 7 comments

Comments

@mikhailnov
Copy link
Contributor

Building with -Wl,--no-undefined:

/usr/bin/ld.default: CMakeFiles/mod-script-pipe.dir/ScripterCallback.cpp.o: in function `__static_initialization_and_destruction_0':
/usr/src/RPM/BUILD/audacity-src-2.4.1/modules/mod-script-pipe/ScripterCallback.cpp:114: undefined reference to `wxArrayString::~wxArrayString()'
/usr/bin/ld.default: CMakeFiles/mod-script-pipe.dir/ScripterCallback.cpp.o:(.data.rel.ro._ZTI20wxThreadHelperThread[_ZTI20wxThreadHelperThread]+0x10): undefined reference to `typeinfo for wxThread'
<...>

Probably wx-config --libs have to be used.

@mikhailnov
Copy link
Contributor Author

CMAKE_EXE_LINKER_FLAGS and CMAKE_MODULE_LINKER_FLAGS seem to be ignored

@mikhailnov
Copy link
Contributor Author

As the resulting binary cannot be underlinked, maybe here there is no sense in try to avoid underlinking

@JamesCrook
Copy link
Contributor

Please explain more clearly.
What do you mean by 'underlinked'?

Is your point about mod-script-pipe (only)?
Is it that mod-script-pipe requires wxWidgets libs?

@mikhailnov
Copy link
Contributor Author

when Audacity is being build with -Wl,--no-undefined, some middle stages of compilation fail because some wx libs are not linked

@lllucius
Copy link
Contributor

when Audacity is being build with -Wl,--no-undefined, some middle stages of compilation fail because some wx libs are not linked

Interesting...I do not see that here and we actually NEED --no-undefined so that the symbols are resolved at runtime, rather than build time.

How are you building?

@mikhailnov
Copy link
Contributor Author

--no-undefined is not needed, but it would be nice to be able to build correctly with it
I actually realized that it is not obligatory to be able to be buildable with --no-undefined a bit after reporting this issue

@JamesCrook
Copy link
Contributor

Closing.
Bug report is unclear. Also:

I actually realized that it is not obligatory to be able to be buildable with --no-undefined a bit after reporting this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants