Skip to content

Fix for running out of file descriptor due to unclosed file #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2018
Merged

Fix for running out of file descriptor due to unclosed file #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/main/java/org/audit4j/core/handler/file/ZeroCopyFileWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ public final class ZeroCopyFileWriter extends AuditFileWriter implements Seriali
/** The path. */
private final String path;

/** To track last opened random access file **/
String lastRealPath;

/**
* Instantiates a new zero copy file writer.
*
Expand Down Expand Up @@ -89,11 +92,15 @@ public ZeroCopyFileWriter write(String event) {
FileHandlerUtil.generateAuditFileName());

try {
if (FileHandlerUtil.isFileAlreadyExists(realPath)) {
randomAccessFile = new RandomAccessFile(realPath, CoreConstants.READ_WRITE);
} else {
randomAccessFile = new RandomAccessFile(new File(realPath), CoreConstants.READ_WRITE);
}
/** Close last instance for random access file. **/
if (randomAccessFile != null && !realPath.equals(lastRealPath)) {
this.stop();
}

if (randomAccessFile == null) {
lastRealPath = realPath;
randomAccessFile = new RandomAccessFile(new File(realPath), CoreConstants.READ_WRITE);
}
} catch (FileNotFoundException e) {
// TODO Auto-generated catch block
e.printStackTrace();
Expand Down