Use :crlf layer with text files for new signatures #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for RT#126938 (https://rt.cpan.org/Ticket/Display.html?id=126938) Setting the binmode layer to ':crlf' seems to do what we want correctly on all platforms. Detect and retain old behavior for old SIGNATURE files so they don't fail verification, but remove Win32 special case since it causes verification failure of some modules. Other changes: - Set SHA256 as default hash since SHA1 is deprecated. - Add --strip-trailing-cr to 'diff' call.
|
Thanks! Released as Module::Signature 0.82. (I've moved the |
|
Nice! Although I forgot to change the version in META.yml, |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for RT#126938
Setting the binmode layer to ':crlf' seems to do what we want correctly on all platforms. Detect and retain old behavior for old SIGNATURE files so they don't fail verification, but remove Win32 special case since it causes verification failure of some modules.
Other changes: