Skip to content

Commit 621bda7

Browse files
committed
fix(bundler): avoid appending alias after comment (sourceMap line).
This fixes tracing npm package "noty".
1 parent 24e2d88 commit 621bda7

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

lib/build/amodro-trace/write/defines.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ function defines(options) {
9696
if (packageName && namedModule && namedModule !== packageName) {
9797
// for main module, if named module name doesn't match package name
9898
// make an alias from moduleName (not packageName) to namedModule
99-
contents += 'define("' + moduleName + '", ["' + namedModule + '"], function(m){return m;});\n';
99+
contents += '\n;define("' + moduleName + '", ["' + namedModule + '"], function(m){return m;});\n';
100100
}
101101
}
102102
}

spec/lib/build/bundled-source.spec.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,7 @@ export {t};
295295
it('transforms npm package js file with named AMD module', () => {
296296
let file = {
297297
path: path.resolve(cwd, 'node_modules/foo/index.js'),
298-
contents: "define('M', ['a', 'b'], function(){});\n"
298+
contents: "define('M', ['a', 'b'], function(){});"
299299
};
300300

301301
let bs = new BundledSource(bundler, file);
@@ -321,8 +321,8 @@ export {t};
321321
let deps = bs.transform();
322322
expect(deps).toEqual(['a', 'b']);
323323
expect(bs.requiresTransform).toBe(false);
324-
expect(bs.contents.replace(/\r|\n/g, ''))
325-
.toBe("define('M', ['a', 'b'], function(){});define(\"foo/index\", [\"M\"], function(m){return m;});");
324+
expect(bs.contents)
325+
.toBe("define('M', ['a', 'b'], function(){});\n;define(\"foo/index\", [\"M\"], function(m){return m;});\n");
326326
});
327327

328328
it('transforms npm package js file with more than one named AMD module', () => {
@@ -355,8 +355,8 @@ export {t};
355355
expect(deps).toEqual(['a', 'b', 'c']);
356356
expect(bs.requiresTransform).toBe(false);
357357
// the alias targets first named module 'M'
358-
expect(bs.contents.replace(/\r|\n/g, ''))
359-
.toBe("define('M', ['a', 'b'], function(){});define('N', ['c'], function(){});define(\"foo/index\", [\"M\"], function(m){return m;});");
358+
expect(bs.contents)
359+
.toBe("define('M', ['a', 'b'], function(){});define('N', ['c'], function(){});\n\n;define(\"foo/index\", [\"M\"], function(m){return m;});\n");
360360
});
361361

362362
it('transforms npm package js file by force cjs wrapper', () => {

0 commit comments

Comments
 (0)