fix(skeleton): fix Promise polyfill on IE

3cp · 3cp · commit bc377dc38e2a · 2019-04-02T11:14:36.000+11:00
Load promise-polyfill before loading aurelia-bootstrapper. The polyfill can be removed if user don't need to support IE. closes #1079
diff --git a/lib/dependencies.json b/lib/dependencies.json
@@ -82,6 +82,7 @@
   "opn": "^5.4.0",
   "postcss-loader": "^3.0.0",
   "postcss-url": "^8.0.0",
+  "promise-polyfill": "^8.1.0",
   "protractor": "^5.4.2",
   "regenerator-runtime": "0.13.2",
   "requirejs": "^2.3.6",
diff --git a/package-lock.json b/package-lock.json
diff --git a/skeleton/cli-bundler/aurelia_project/aurelia.json b/skeleton/cli-bundler/aurelia_project/aurelia.json
@@ -144,6 +144,7 @@
       {
         "name": "vendor-bundle.js",
         "prepend": [
+          "node_modules/promise-polyfill/dist/polyfill.min.js",
           // @if feat.requirejs
           "node_modules/requirejs/require.js"
           // @endif
diff --git a/skeleton/common/package.json b/skeleton/common/package.json
@@ -25,6 +25,7 @@
     "minimatch": "",
     "through2": "",
     "vinyl-fs": "",
+    "promise-polyfill": "",
 
     // @if feat.babel
     "regenerator-runtime": "",
diff --git a/skeleton/webpack/webpack.config.js b/skeleton/webpack/webpack.config.js
@@ -287,6 +287,7 @@ module.exports = ({ production, server, extractCss, coverage, analyze, karma } =
       $: 'jquery',
       jQuery: 'jquery',
     // @endif
+      'Promise': ['promise-polyfill', 'default']
     }),
     new ModuleDependenciesPlugin({
       'aurelia-testing': ['./compile-spy', './view-spy']

Original file line number	Diff line number	Diff line change
`@@ -144,6 +144,7 @@`
`144`	`144`	`{`
`145`	`145`	`"name": "vendor-bundle.js",`
`146`	`146`	`"prepend": [`
	`147`	`+ "node_modules/promise-polyfill/dist/polyfill.min.js",`
`147`	`148`	`// @if feat.requirejs`
`148`	`149`	`"node_modules/requirejs/require.js"`
`149`	`150`	`// @endif`