Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CredentialsManager: Allow to pass scope and minTTL #363

Merged
merged 8 commits into from
Oct 30, 2020
Merged

CredentialsManager: Allow to pass scope and minTTL #363

merged 8 commits into from
Oct 30, 2020

Commits on Oct 30, 2020

  1. allow to pass minTTL and scope to the CredentialsManager

    @lbalmaceda
    lbalmaceda committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    44cdbba View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Rita Zerrizuela <zeta@widcket.com>
    @lbalmaceda @Widcket
    lbalmaceda and Widcket committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    9e9eec0 View commit details
    Browse the repository at this point in the history

  3. chore PR review comments

    @lbalmaceda
    lbalmaceda committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    3545cc1 View commit details
    Browse the repository at this point in the history

  4. add additional test case

    @lbalmaceda
    lbalmaceda committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    460362e View commit details
    Browse the repository at this point in the history

  5. update minTTL condition to apply only for access tokens

    @lbalmaceda
    lbalmaceda committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    ff3aa0f View commit details
    Browse the repository at this point in the history

  6. add fallback for when cache expires at is not set

    @lbalmaceda
    lbalmaceda committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    74e8591 View commit details
    Browse the repository at this point in the history

  7. accept minTtl when checking for credentials existence

    @lbalmaceda
    lbalmaceda committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    e36adc6 View commit details
    Browse the repository at this point in the history

  8. fix test exception message assertion

    @lbalmaceda
    lbalmaceda committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    e1909c5 View commit details
    Browse the repository at this point in the history