Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Logging for Requests/Responses and Uri's. #40

Merged
merged 5 commits into from
Nov 30, 2016
Merged

Add Logging for Requests/Responses and Uri's. #40

merged 5 commits into from
Nov 30, 2016

Conversation

lbalmaceda
Copy link
Contributor

@lbalmaceda lbalmaceda commented Nov 23, 2016 •
edited
Loading

Logging is disabled by default. Usage:

WebAuthProvider.init(account)
    .setLoggingEnabled(true)
    .start(activity, callback);

or in the API Clients

AuthenticationAPIClient authClient = new AuthenticationAPIClient(account);
authClient.setLoggingEnabled(true);

UsersAPIClient usersClient = new UsersAPIClient(account);
usersClient.setLoggingEnabled(true);

@hzalaz hzalaz added this to the 1.2.0 milestone Nov 25, 2016
@lbalmaceda lbalmaceda mentioned this pull request Nov 29, 2016
Closed
hzalaz
hzalaz suggested changes Nov 30, 2016
View reviewed changes
auth0/src/main/java/com/auth0/android/provider/WebAuthProvider.java
@@ -341,6 +353,9 @@ private boolean authorize(@NonNull AuthorizeResult data) {
Log.w(TAG, "The response didn't contain any of these values: code, state, id_token, access_token, token_type, refresh_token");
return false;
}
if (loggingEnabled) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can do better than copy-pasting an if

@hzalaz hzalaz merged commit dbba9d2 into master Nov 30, 2016
@hzalaz hzalaz deleted the http-logging branch November 30, 2016 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzalaz hzalaz hzalaz approved these changes

Assignees

@hzalaz hzalaz

Labels
CH: Added
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lbalmaceda @hzalaz