Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for PasswordChangeTicket with Email #187

Merged

Conversation

pedes
Copy link
Contributor

@pedes pedes commented Feb 9, 2019

Improved unit test coverage, and added a unit test for covering the case of creating a PasswordChangeTicket using an email and custom connection as parameters.

Improved from 70% to 100
screen shot 2019-02-09 at 22 02 33
screen shot 2019-02-09 at 22 21 06

%.

Improved unit test coverage, and added a unit test for covering the case of creating a PasswordChangeTicket using an email and custom connection as parameters.

Improved from 73% to 93%.
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that only invoking the other constructor would be enough for the coverage to go up to 100%, since the rest of the setters are called in the test right above it. But it's no harm to duplicate those other checks. Thanks!

@lbalmaceda lbalmaceda added this to the v1-Next milestone Apr 23, 2019
@lbalmaceda lbalmaceda merged commit 57e9024 into auth0:master Apr 23, 2019
@lbalmaceda lbalmaceda modified the milestones: v1-Next, 1.13.0 Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants