Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add rotating_refresh_token to DeviceCredentials token types. #250

Merged
merged 1 commit into from
Apr 23, 2020
Merged

[docs] Add rotating_refresh_token to DeviceCredentials token types. #250

merged 1 commit into from
Apr 23, 2020

Conversation

damieng
Copy link
Contributor

@damieng damieng commented Apr 23, 2020

Just doc comments for DeviceCredentials.Type missing the new rotating_refresh_token type.

@damieng damieng requested a review from a team April 23, 2020 18:18
@damieng damieng added the tiny label Apr 23, 2020
lbalmaceda
lbalmaceda approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only docs?? 👍

@lbalmaceda lbalmaceda merged commit bef1ae3 into master Apr 23, 2020
@lbalmaceda lbalmaceda deleted the rotating_refresh_token_comment branch April 23, 2020 18:43
@lbalmaceda lbalmaceda changed the title Add rotating_refresh_token to devicecredential token types. [docs] Add rotating_refresh_token to DeviceCredentials token types. Apr 23, 2020
@lbalmaceda lbalmaceda added this to the v1-Next milestone Apr 23, 2020
@damieng
Copy link
Contributor Author

damieng commented Apr 23, 2020

In the .NET SDK instead of strings we use enums for these so it's a bigger change but here it just looks like it passes unconstrained strings back and forth.

@lbalmaceda
Copy link
Contributor

We could also use enums and fix the values to the ones we whitelist in there, but given how often things change in the API I rather leave the validation to the server 😬

@jimmyjames jimmyjames modified the milestones: v1-Next, 1.16.0 Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
tiny
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@damieng @lbalmaceda @jimmyjames