Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JS incompatibility check during tests #1543

Merged
merged 2 commits into from
Nov 6, 2018
Merged

Add JS incompatibility check during tests #1543

merged 2 commits into from
Nov 6, 2018

Conversation

luisrudge
Copy link
Contributor

Changes

This check will prevent issues like this from happening again.

joshcanhelp
joshcanhelp approved these changes Nov 6, 2018
View reviewed changes
Copy link
Contributor

@joshcanhelp joshcanhelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luisrudge luisrudge merged commit fe95c32 into master Nov 6, 2018
@luisrudge luisrudge deleted the feature/es-check branch November 6, 2018 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshcanhelp joshcanhelp joshcanhelp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luisrudge @joshcanhelp