Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-3087] Captcha for single enterprise AD connections #2096

Merged
merged 5 commits into from
Feb 8, 2022

Conversation

stevehobbsdev
Copy link
Contributor

@stevehobbsdev stevehobbsdev commented Feb 6, 2022

Changes

This change adds in support for Bot Protection Captcha challenges for connections where there is only one connection, and that connection is an enterprise AD/ADLDAP connection.

References

Internal tickets: SDK-3087, ESD-17783
#2071

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@stevehobbsdev stevehobbsdev added the review:medium Medium review label Feb 6, 2022
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Feb 6, 2022

This pull request fixes 1 alert when merging 7c97f36 into 7552d24 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Feb 6, 2022

This pull request fixes 1 alert when merging dbe35d5 into 7552d24 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Feb 6, 2022

This pull request fixes 1 alert when merging 81e7173 into 7552d24 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@stevehobbsdev stevehobbsdev marked this pull request as ready for review February 6, 2022 22:01
@stevehobbsdev stevehobbsdev requested a review from a team as a code owner February 6, 2022 22:01
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Feb 6, 2022

This pull request fixes 1 alert when merging d95c7d5 into 7552d24 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Feb 7, 2022

This pull request fixes 1 alert when merging 4bf7bb7 into 7552d24 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@stevehobbsdev stevehobbsdev merged commit dce864a into master Feb 8, 2022
@stevehobbsdev stevehobbsdev deleted the sdk-3087/hrd-captcha branch February 8, 2022 14:54
@stevehobbsdev stevehobbsdev mentioned this pull request Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:medium Medium review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants