Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate UsersManager.deleteAll and deleteAllUsers wrapper methods #309

Merged
merged 1 commit into from
Oct 31, 2018

Conversation

M-Zuber
Copy link
Contributor

@M-Zuber M-Zuber commented Oct 30, 2018

Fixes #174

@luisrudge
Copy link
Contributor

Thanks for the PR @M-Zuber, but we can't remove this without releasing a new major version. We can, however, mark it as a deprecated method, saying we'll remove it in the next major. Can you change your PR to do that instead?

@M-Zuber
Copy link
Contributor Author

M-Zuber commented Oct 30, 2018

Sure!

  • Is there specific text that should be provided in the deprecation message?
  • if it is only being deprecated, should the tests be put back as well?

@luisrudge
Copy link
Contributor

If you want to start a new PR, it might be easier/faster.

An example of a deprecation:

* @deprecated The function name has a typo.

You can use This method will be removed in the next major. That's fine for now. Thanks! 🎉

@M-Zuber M-Zuber changed the title Remove UsersManager.deleteAll and deleteAllUsers wrapper method Deprecate UsersManager.deleteAll and deleteAllUsers wrapper methods Oct 30, 2018
@M-Zuber
Copy link
Contributor Author

M-Zuber commented Oct 30, 2018

I force pushed the changes. Please let me know it anything else needs to be done

@luisrudge
Copy link
Contributor

Thanks 🎉

@luisrudge luisrudge merged commit 30ac10a into auth0:master Oct 31, 2018
@luisrudge luisrudge added this to the v2.14.0 milestone Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants