Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade to Sinatra 3 and use Rack::Session::Cookie in tests #165

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

stevehobbsdev
Copy link
Contributor

Changes

This fixes an issue with a test that verifies how the authorization params are written to the session (as a plain hash) that does not work using Sinatra 3. The default session store for 3 was changed Rack::Protection::EncryptedCookie, and this test does not take into account the cookie being encrypted.

This PR:

  • Upgrades Sinatra to 3
  • Uses the Sinatra 2 default cookie store of Rack::Session::Cookie for the purposes of tests

References

Fixes #162

Testing

This change was tested manually using the debian:sid Docker image.

@stevehobbsdev stevehobbsdev requested a review from a team as a code owner February 28, 2023 22:52
@stevehobbsdev stevehobbsdev merged commit 6036402 into master Mar 1, 2023
@stevehobbsdev stevehobbsdev deleted the fix/sinatra-3-spec branch March 1, 2023 10:45
@stevehobbsdev stevehobbsdev mentioned this pull request Mar 1, 2023
@stevehobbsdev stevehobbsdev mentioned this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: incompatible marshal file format (can't be read) format version 4.8 required; 216.25 given
2 participants