[SDK-4410] Support Organization Name in JWT validation #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
reviewed
Jul 13, 2023
| }))) | ||
| end | ||
|
|
||
| it 'should fail when authorize params has organization but token org_id does not match' do |
There was a problem hiding this comment.
Should we add an equivalent test for org_name?
There was a problem hiding this comment.
Absolutely, thanks for catching that. Fixed in d741106
Widcket
approved these changes
Jul 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds support for
org_nameclaim validation in the JWT validator.Testing
Checklist