Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add telemetry to token endpoint #74

Merged
merged 2 commits into from
Feb 21, 2019
Merged

Add telemetry to token endpoint #74

merged 2 commits into from
Feb 21, 2019

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Feb 19, 2019 •
edited

Changes

  • Add OmniAuth::Auth0::Telemetry to contain all telemetry-related functionality
  • Add override build_access_token method to the spec to add the telemetry header

References

Testing

  • This change adds unit test coverage for these changes and authorize URL telemetry

Checklist

  • All existing and new tests complete without errors
  • All code quality tools/guidelines

@joshcanhelp joshcanhelp added this to the v2-Next milestone Feb 19, 2019
@luisrudge
Copy link

LGTM

@joshcanhelp joshcanhelp merged commit fcd09b1 into master Feb 21, 2019
@joshcanhelp joshcanhelp deleted the add-telemetry-to-token-ep branch February 21, 2019 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CH: Added
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshcanhelp @luisrudge