Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved OIDC Compliance #92

Merged
merged 2 commits into from
Mar 3, 2020
Merged

Improved OIDC Compliance #92

merged 2 commits into from
Mar 3, 2020

Conversation

davidpatrick
Copy link
Contributor

@davidpatrick davidpatrick commented Feb 21, 2020 •
edited

Changes

  • Adds proper error handling in the callback phase
  • Improves OIDC Compliance with ID Token Validation
  • Fixes issue with JWTValidator decode returning an array, and not the expected hash

Tests

  • Tests cover all scenarios of id token validation

@davidpatrick davidpatrick requested a review from a team February 21, 2020 17:08
@davidpatrick davidpatrick force-pushed the oidc_compliance branch 3 times, most recently from a1d7e7b to b0bfa69 Compare February 21, 2020 23:30
@davidpatrick davidpatrick mentioned this pull request Feb 21, 2020
Closed
6 tasks
@adamjmcgrath adamjmcgrath requested review from adamjmcgrath and removed request for a team February 25, 2020 10:58
adamjmcgrath
adamjmcgrath previously approved these changes Feb 27, 2020
View reviewed changes
@davidpatrick davidpatrick requested review from lbalmaceda and jimmyjames and removed request for lbalmaceda February 27, 2020 19:50
jimmyjames
jimmyjames requested changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@jimmyjames jimmyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor suggestions and questions.

lib/omniauth/auth0/jwt_validator.rb Outdated Show resolved Hide resolved
lib/omniauth/auth0/jwt_validator.rb Show resolved Hide resolved
spec/omniauth/auth0/jwt_validator_spec.rb Outdated Show resolved Hide resolved
lib/omniauth/strategies/auth0.rb Show resolved Hide resolved
jimmyjames
jimmyjames previously approved these changes Feb 29, 2020
View reviewed changes
@lbalmaceda lbalmaceda closed this Mar 2, 2020
@lbalmaceda lbalmaceda reopened this Mar 2, 2020
@lbalmaceda
Copy link
Contributor

@davidpatrick ready for you

@davidpatrick davidpatrick merged commit 3c7b8cd into auth0:master Mar 3, 2020
@davidpatrick davidpatrick added this to the 2.3.0 milestone Mar 6, 2020
@davidpatrick davidpatrick mentioned this pull request Mar 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmyjames jimmyjames jimmyjames approved these changes

@adamjmcgrath adamjmcgrath adamjmcgrath left review comments

Assignees
No one assigned
Labels
CH: Added
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@davidpatrick @lbalmaceda @jimmyjames @adamjmcgrath