Fix "NameError: uninitialized constant OmniAuth::Auth0::TokenValidationError" #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanwork
changed the title
|
Done. |
|
Thanks for this fix. I am currently hitting this error in local dev when I have an exception in my auth0 controller callback action . |
relston
approved these changes
Mar 26, 2020
davidpatrick
approved these changes
Mar 27, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This fixes the following error:
in case there's an error inside of
callback_phase. In our case, the error was a DNS resolution error. This caused the wrong error to display in our exception reporting system (but digging in revealed the DNS error).I think 2.3.1 should be released with this fix.
References
N/A
Testing
rspec still passes.
Checklist