Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Self Service Profile SSO #1008

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

duedares-rvj
Copy link
Contributor

@duedares-rvj duedares-rvj commented Aug 22, 2024

🔧 Changes

  1. Added a new resource schema auth0_self_service_profile
  2. Added a new data source schema auth0_self_service_profile
  3. Added relevant expand and flatten rules.
  4. Added relevant test cases for data_source and resource.
  5. Added test recordings.
  6. Added relevant docs and examples.

📚 References

Create a self service profile
Get a self service profile
Update a self-service profile
Delete a self-service profile by Id

🔬 Testing

All relevant test cases has been added for create, get, update and delete functionality through terraform.
Also includes negative testing.

  1. testSelfServiceProfileCreate
  2. testSelfServiceProfileUpdate
  3. testDataResourceWithoutID
  4. testDataResourceWithValidID
  5. testDataResourceWithInvalidID

make test FILTER=testSelfServiceProfileCreate

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@duedares-rvj duedares-rvj self-assigned this Aug 22, 2024
@duedares-rvj duedares-rvj marked this pull request as ready for review August 22, 2024 21:04
@duedares-rvj duedares-rvj requested a review from a team as a code owner August 22, 2024 21:04
@duedares-rvj duedares-rvj requested a review from acwest August 22, 2024 21:04
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 88.26087% with 27 lines in your changes missing coverage. Please review.

Project coverage is 90.35%. Comparing base (1d8a8e8) to head (32135dd).

Files Patch % Lines
internal/auth0/selfserviceprofile/resource.go 90.08% 8 Missing and 4 partials ⚠️
internal/auth0/selfserviceprofile/expand.go 80.00% 6 Missing and 3 partials ⚠️
internal/auth0/selfserviceprofile/flatten.go 84.61% 4 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main    #1008    +/-   ##
========================================
  Coverage   90.34%   90.35%            
========================================
  Files         105      109     +4     
  Lines       14341    14571   +230     
========================================
+ Hits        12956    13165   +209     
- Misses        982      996    +14     
- Partials      403      410     +7     
Files Coverage Δ
internal/auth0/selfserviceprofile/data_source.go 100.00% <100.00%> (ø)
internal/provider/provider.go 100.00% <ø> (ø)
internal/auth0/selfserviceprofile/flatten.go 84.61% <84.61%> (ø)
internal/auth0/selfserviceprofile/expand.go 80.00% <80.00%> (ø)
internal/auth0/selfserviceprofile/resource.go 90.08% <90.08%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@developerkunal developerkunal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duedares-rvj duedares-rvj changed the title Added new schema, relevant test cases and documentation for Self Service Profile SSO Add Self Service Profile SSO Aug 26, 2024
@developerkunal developerkunal changed the title Add Self Service Profile SSO Add support for Self Service Profile SSO Aug 26, 2024
@duedares-rvj duedares-rvj merged commit 6b39f7c into main Aug 26, 2024
8 checks passed
@duedares-rvj duedares-rvj deleted the DXCDT-688/SelfServiceProfile branch August 26, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants