Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set connection settings and attribute map as computed #845

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

sergiught
Copy link
Contributor

🔧 Changes

If not provided, the connection_settings and attribute_map will be set to a default on OIDC and Okta connections, so we're setting this as computed and adjusting the tests.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught requested a review from a team as a code owner September 19, 2023 17:39
@codecov-commenter
Copy link

Codecov Report

Merging #845 (4a693b5) into main (d1f827e) will increase coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #845      +/-   ##
==========================================
+ Coverage   89.89%   89.93%   +0.04%     
==========================================
  Files         101      101              
  Lines       13785    13785              
==========================================
+ Hits        12392    12398       +6     
+ Misses        989      985       -4     
+ Partials      404      402       -2     

see 1 file with indirect coverage changes

@sergiught sergiught merged commit dfbfd37 into main Sep 19, 2023
@sergiught sergiught deleted the fix-oidc-okta-tests branch September 19, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants