Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding local debugging #89

Merged
merged 8 commits into from
Nov 17, 2016
Merged

Adding local debugging #89

merged 8 commits into from
Nov 17, 2016

Conversation

glennblock
Copy link
Contributor

@glennblock glennblock commented Nov 13, 2016

This PR introduces local debugging using [devtool] (https://github.com/Jam3/devtool) or using IDE's like VSCode which support node debugging. In it's current form, it requires the task to be local and all the required modules to be present in the local node_modules folder or a parent folder.

To enable the debugging feature the debug command is introduced.

  • wt debug task.js - launches task.js using the node debugger. This allows debugging using a tool such as VS Code which supports connecting to the node debugger port.
  • wt debug task.js --debugger=devtool - debugs task.us using the Electron based Devtool. The debugger will pop up. Devtool must be installed for this to work.

Copy link
Contributor

@ggoodman ggoodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

newArgs = [process.argv[1], 'serve']
_.each(process.argv.slice(3), (value)=> {
var arg = value.toLowerCase();
if (!(arg === 'debug' || (arg.startsWith('--debugger=') || arg.startsWith('-d')))) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String.prototype.startsWith, where have you been all my life?

@ggoodman ggoodman merged commit 9cddf1d into auth0:master Nov 17, 2016
@glennblock
Copy link
Contributor Author

👍
On Wed, Nov 16, 2016 at 5:04 PM Geoff Goodman notifications@github.com
wrote:

Merged #89 #89.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#89 (comment), or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAInRIze7CEQVRbndC_J7kgoZsGh-YFVks5q-6gYgaJpZM4Kwn_4
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants